Texture: Add setValues. #1659
Merged
Texture: Add setValues. #1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types for mrdoob/three.js#31087 which is used to ensure texture parameters are passed correctly from render target options (2D, 3D, array). I do use the word parameters for the interface, unsure if options is preferable even though the
Textureconstructor only has arguments.See https://github.com/mrdoob/three.js/pull/31087/files#diff-3d1e11ad5043fb6ad5c8b8a55be022f7ba2e3228b34016a073524f32af2aec8cR205 for relevant diff to texture parameters.