This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Expose charsets as Hash in normalized params #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse the JSON string and return a Hash with symbol keys for ease of use by Griddler later on. This is useful for encoding strings properly. We are currently running into an issue where we receive text bodies containing non-UTF8 characters. We want to convert them to UTF8 using String#encode, but without knowing the source encoding, we cannot do this correctly. This surfaces the encodings that were pulled out by SendGrid so that we can access them from the Griddler Email.
heidi
changed the title
|
@heidi sorry for late review, I haven't been using this gem recently. Is this PR dependent on merging thoughtbot/griddler#292 ? |
|
It can be merged independently, but won't be very useful until the PR you reference is also merged. |
|
That PR just got merged. I'll have to cut a new release later tonight though. I'll merge this PR as well and release it with |
|
Woot! Thanks for the help @heidi this is good 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the JSON string and return a Hash with symbol keys
for ease of use by Griddler when encoding strings later on.
We are currently running into an issue where we receive bodies
containing non-UTF8 characters. We want to convert them to UTF8
using String#encode, but without knowing the source encoding, we
cannot do this correctly. This surfaces the encodings that were
pulled out by SendGrid so that we can access them from the
Griddler Email.