Conversion issue since v0.23.5

[agray]

in version 0.23.5, 0.24.0 and 0.25.0 I am getting 4 instances of the error

Cannot implicitly convert type 'int[]' to 'int'

These classes have not changed in years. I am only updating the nuget packages and have released Saucery.TUnit in lock step with TUnit.

Given its in the generated file, what source line in my source code does it relate to and why is it broken?

[Brokolis]

I believe I'm getting a similar error upgrading from 0.22.12 to 0.24.0. It seems like MethodDataSourceAttribute.Arguments are broken.

I'm getting this error:

0>NodeAnalyzerTests-d05cf628878d476c9c4978c8017c2493.Generated.cs(97,130): Error CS9174 : Cannot initialize type 'bool' with a collection expression because the type is not constructible.

The generated file has the error in this line:

foreach (var methodDataAccessor in global::MediaOrganizer.Tests.Analyzing.NodeAnalyzerTests.IsOnlyExtra_ShouldReturn_Data([true]))

The NodeAnalyzerTests.IsOnlyExtra_ShouldReturn_Data method looks like this:

public static IEnumerable<(string Input, bool ExpectedResult)> IsOnlyExtra_ShouldReturn_Data(bool includeAndSeparator)

And it is being referenced like this:

[Test]
[MethodDataSource(nameof(IsOnlyExtra_ShouldReturn_Data), Arguments = [true])]
public void IsOnlyExtra_ShouldReturn(string input, bool expectedResult)

[thomhurst]

You guys got a repro I can clone?

[agray]

I can get you one.

[agray]

See here:
https://github.com/Sauceforge/Saucery/tree/bug/tunitbroken

[agray]

Got this working (only on 0.25.6) with this:

[MethodDataSource(nameof(AllCombinations), Arguments = new object?[] { new int[] { 4, 5 } })]

But it doesn't currently work with this (previously it did):

[MethodDataSource(nameof(AllCombinations), Arguments = [ new int[] { 4, 5 } ])]

It would compile with a warning but not enumerate at runtime.

Also Codacy doesn't like it:

[agray]

Still an issue in v0.25.21