doc: Add s3 retriever v1 deprecation notice; add v2 links #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example uses v2, so the links to v1 stuff in the original doc may need to be updated.
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1618 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 77 77
Lines 3654 3654
=======================================
Hits 3216 3216
Misses 354 354
Partials 84 84 ☔ View full report in Codecov by Sentry. |
thomaspoignant
approved these changes
Mar 12, 2024
Owner
thomaspoignant
left a comment
thomaspoignant
left a comment
There was a problem hiding this comment.
Oh, good catch 👍.
I'll merge that now, the doc update will be available in the next release.
|
thomaspoignant
added a commit
that referenced
this pull request
Sep 5, 2024
The example uses v2, so the links to v1 stuff in the original doc may need to be updated. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Thomas Poignant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The example uses v2, so the links to v1 stuff in the original doc may need to be updated.
Checklist
README.mdand/website/docs)