Skip to content

Throw an exception when an Elasticsearch bulk request fails #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: titan05
Choose a base branch
from
Open

Throw an exception when an Elasticsearch bulk request fails #1157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1774e20
Add TODOs where bulk handling should be improved
srosenthal Sep 10, 2015
a574158
Throw an exception when an Elasticsearch bulk request fails
srosenthal Sep 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions titan-es/src/main/java/com/thinkaurelius/titan/diskstorage/es/ElasticSearchIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
import org.elasticsearch.action.admin.indices.exists.indices.IndicesExistsRequest;
import org.elasticsearch.action.admin.indices.exists.indices.IndicesExistsResponse;
import org.elasticsearch.action.admin.indices.mapping.put.PutMappingResponse;
import org.elasticsearch.action.bulk.BulkItemResponse;
import org.elasticsearch.action.bulk.BulkRequestBuilder;
import org.elasticsearch.action.bulk.BulkResponse;
import org.elasticsearch.action.delete.DeleteRequest;
import org.elasticsearch.action.index.IndexRequest;
import org.elasticsearch.action.search.SearchRequestBuilder;
Expand All @@ -46,6 +48,7 @@
import org.elasticsearch.indices.IndexMissingException;
import org.elasticsearch.node.Node;
import org.elasticsearch.node.NodeBuilder;
import org.elasticsearch.rest.RestStatus;
import org.elasticsearch.search.SearchHit;
import org.elasticsearch.search.SearchHits;
import org.elasticsearch.search.sort.FieldSortBuilder;
Expand Down Expand Up @@ -561,7 +564,10 @@ public void mutate(Map<String, Map<String, IndexMutation>> mutations, KeyInforma

}
}
if (bulkrequests > 0) brb.execute().actionGet();
if (bulkrequests > 0) {
BulkResponse bulkResponse = brb.execute().actionGet();
checkBulkResponseForFailures(bulkResponse);
}
} catch (Exception e) {
throw convert(e);
}
Expand Down Expand Up @@ -595,13 +601,38 @@ public void restore(Map<String,Map<String, List<IndexEntry>>> documents, KeyInfo
}
}

if (requests > 0)
bulk.execute().actionGet();
if (requests > 0) {
BulkResponse bulkResponse = bulk.execute().actionGet();
checkBulkResponseForFailures(bulkResponse);
}
} catch (Exception e) {
throw convert(e);
}
}

/**
* If a BulkResponse has a failure except for {@link RestStatus#NOT_FOUND}, throw an exception.
*
* @param bulkResponse
* a BulkResponse to be analyzed
*
* @throws Exception
* if any of the requests failed
*/
private static void checkBulkResponseForFailures(BulkResponse bulkResponse) throws Exception {
if (bulkResponse.hasFailures()) {
for (BulkItemResponse bulkItemResponse : bulkResponse.getItems()) {
// We don't need to update a document if it's been deleted
// If it failed for a different reason, this is an "actual" failure
boolean actualFailure = bulkItemResponse.isFailed() &&
bulkItemResponse.getFailure().getStatus() != RestStatus.NOT_FOUND;
if (actualFailure) {
throw new Exception(bulkResponse.buildFailureMessage());
}
}
}
}

public FilterBuilder getFilter(Condition<?> condition, KeyInformation.StoreRetriever informations) {
if (condition instanceof PredicateCondition) {
PredicateCondition<String, ?> atom = (PredicateCondition) condition;
Expand Down