Skip to content

tplg_parser :Validate control name length #10361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Biancaa-R wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tplg_parser :Validate control name length #10361

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1ffbdb
tplg_parser: add string length validation names
Nov 10, 2025
4cf567f
Merge branch 'thesofproject:main' into validate-control-name-len
Biancaa-R Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tools/tplg_parser/control.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,16 @@ int tplg_create_controls(struct tplg_context *ctx, int num_kcontrols,
for (j = 0; j < num_kcontrols; j++) {

ctl_hdr = tplg_get(ctx);

#define MAX_CONTROL_NAME_LEN 64
Copy link
Member

@lgirdwood lgirdwood Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be found in an ALSA header file.

Copy link
Author

@Biancaa-R Biancaa-R Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay .

Copy link
Author

@Biancaa-R Biancaa-R Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood is this approach fine or should I change the test in any other better way?

Copy link
Member

@lgirdwood lgirdwood Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to #include the correct ALSA header file and use its macro for this size.

// if (strlen(ctl_hdr->name) > MAX_CONTROL_NAME_LEN) {
// fprintf(stderr, "error: control name too long: %s\n", ctl_hdr->name);
// return -EINVAL;
// }
Comment on lines +103 to +107
Copy link
Member

@lgirdwood lgirdwood Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assume this will be an error message too when ready ?

mixer_ctl = (struct snd_soc_tplg_mixer_control *)ctl_hdr;
if (strlen(mixer_ctl->name) > MAX_CONTROL_NAME_LEN) {
fprintf(stderr, "error: control name too long: %s\n", mixer_ctl->name);
return -EINVAL;
Copy link
Collaborator

@lyakh lyakh Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix indentation

}
/* load control based on type */
switch (ctl_hdr->ops.info) {
case SND_SOC_TPLG_CTL_VOLSW:
Expand Down