Skip to content

Ft/disable http2 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 24, 2023
Merged

Ft/disable http2 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d198322
Disable http2 in server
thepetk Nov 15, 2023
1d14281
Add env var for http2 enablement
thepetk Nov 24, 2023
26386e4
Fix typo for env var
thepetk Nov 24, 2023
58e5689
Add env var to dockerfile
thepetk Nov 24, 2023
e910cec
Fix ci.yaml workflow
thepetk Nov 24, 2023
cbbac60
Fix typo in the workflows
thepetk Nov 24, 2023
9dbf64b
Merge branch 'main' into ft/disable_http2
thepetk Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_registry.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ BASE_DIR=$(dirname $0)
. ${BASE_DIR}/setenv.sh

# Build the index server base image
. ${BASE_DIR}/index/server/build.sh
ENABLE_HTTP2="false" . ${BASE_DIR}/index/server/build.sh

# Build the test devfile registry image
docker build -t devfile-index:latest -f ${BASE_DIR}/.ci/Dockerfile ${BASE_DIR}
4 changes: 4 additions & 0 deletions index/server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ RUN set -x ; \
# Modify the permissions on the necessary files to allow the container to properly run as a non-root UID
RUN mkdir -p /www/data && chmod -R g+rwx /www/data

# disable http/2 on the index server by default
ARG ENABLE_HTTP2=false
ENV ENABLE_HTTP2=${ENABLE_HTTP2}

# Set env vars for the locations of the devfile stacks and index.json
ENV DEVFILE_STACKS /registry/stacks
ENV DEVFILE_SAMPLES /registry/samples
Expand Down
2 changes: 1 addition & 1 deletion index/server/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ buildfolder="$(realpath $(dirname ${BASH_SOURCE[0]}))"
bash ${buildfolder}/codegen.sh

# Build the index server
docker build -t devfile-index-base:latest $buildfolder --build-arg ENABLE_HTTP2=${ENABLE_HTTP2}
docker build -t devfile-index-base:latest --build-arg ENABLE_HTTP2=${ENABLE_HTTP2} $buildfolder