Skip to content

🐛 mkdirSync recursively #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2021
Merged

🐛 mkdirSync recursively #30

merged 1 commit into from
Oct 2, 2021

Conversation

trhinehart-godaddy
Copy link
Contributor

Summary

Support writing to nested output.path.

Why

Without the recursive flag, any subdirectory that doesn't exist will throw.

Checklist

  • Your code builds clean without any errors or warnings
  • You are using approved terminology
  • You have added unit tests, if apply.

themgoncalves
themgoncalves approved these changes Oct 2, 2021
View reviewed changes
Copy link
Owner

@themgoncalves themgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM!

@themgoncalves themgoncalves merged commit 803d356 into themgoncalves:master Oct 2, 2021
@trhinehart-godaddy trhinehart-godaddy deleted the patch-2 branch October 4, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themgoncalves themgoncalves themgoncalves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trhinehart-godaddy @themgoncalves