Conversation
This project was processing dates without proper consideration of their timezones. As such, several bizarre errors errors were happening, especially around the start and end of a sprint. For example, issues closed at 6pm Arizona time on the last day of the sprint were not having their points credited to that day on the burndown chart because GitHub returned that closed date as 1am UTC the following day. This project now processes all dates internally using UTC. The `sprint_start_date` and `sprint_end_date` are assumed to be at 00:00:00 *local time*, and the final burndown chart is rendered in local time. These changes fix #17 and fix #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project was processing dates without proper consideration of
their timezones. As such, several bizarre errors errors were
happening, especially around the start and end of a sprint.
For example, issues closed at 6pm Arizona time on the last day of
the sprint were not having their points credited to that day on
the burndown chart because GitHub returned that closed date as
1am UTC the following day.
This project now processes all dates internally using UTC. The
sprint_start_dateandsprint_end_dateare assumed to beat 00:00:00 local time, and the final burndown chart is
rendered in local time.
These changes fix #17 and fix #21