This repository was archived by the owner on Mar 21, 2023. It is now read-only.
Make multiple changes to the haxe grammar, detailed below. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds Regex Highlighting * Highlights multiple type parameters in a useful way * Higlights nested type parameteres in a useful way * Introduces a user-defined constant concept (variable with name in all caps) Though most of the functionality is the same, this commit replaces the entire haxe grammar file with a different one which uses the grammar repository more heavily.
Control-flow keywords given the name 'keyword.control.haxe.flow-control.2' again in order to pass automatic testing. Field-completions included from repository to pass testing. Includes expanded to multiple lines to match existing grammar code style.
Author
|
Getting some errors that are not obviously related to the grammar in testing. Going to look into that and reopen when finished. |
Error was caused by two invalid rule references in #field-completions.
Author
|
Fixed the lingering error. I think these changes result in a more readable grammar, but it's also almost a complete replacement of the original file. If you wanted the effects of these changes but in a series of commits with a less crazy diff I could probably do that too. |
…etions. Class names, and CAPS_CONSTANTS now included in field-completions. New Keyword is matched on its own there too.
…ant. User-contstants can now be a single uppercase character.
…ions. Operators are now a higher priority than constants (most notably numbers with a '+' or '-' in front. New functions will now highlight within the argument lists of other functions.
Keywords 'import', 'using', 'as', and 'in' now highlight before corresponding statements are completed. The classifier for these keywords in now 'keyword.type.import.haxe'.
Classification is now 'keyword.type.package.haxe'. Highlights without a supplied package name (which valid syntax for packages).
First includes #field-completions within the parentheses-surrounded form of itself. Second ensures that for the first form, the dot beginning the pattern is followed by one of `[A-Za-z_]`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though most of the functionality is the same, this commit replaces the
entire haxe grammar file with a different one which uses the grammar
repository more heavily.