Fix resource leak on malloc failure in pcap-linux.c #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyharris
reviewed
Jul 24, 2025
moon044
force-pushed
the
fix-resource-leak-pcap-linux
branch
from
e191d41 to
4a3a4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this fixes
Hi,
This PR fixes a resource leak in
pcap-linux.c.If
malloc()fails after opening a socket, the file descriptor is not closed, which can cause a resource leak.Fix
Added
close(sock_fd);before returning on allocation failure.Thank you for the review!