refactor: extract internal message answer entrypoint#2244
Merged
hsluoyz merged 1 commit intoMay 9, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the message-answer SSE flow by extracting a reusable internal entrypoint and consolidating SSE error-stream writing logic, with the intent of keeping the public /get-message-answer behavior unchanged while enabling reuse by future internal integrations (e.g., pipes/webhooks).
Changes:
- Extracts a reusable internal message-answer entrypoint (
generateMessageAnswer) that accepts anhttp.ResponseWriterandhost. - Extracts SSE error-stream writing into a shared helper (
writeMessageErrorStream) and updates call sites to reuse it. - Replaces direct controller writer usage (
c.Ctx.ResponseWriter) with an injectedresponseWriterwithin the extracted flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| controllers/message_util.go | Extracts SSE error-stream emission into writeMessageErrorStream and reuses it from ResponseErrorStream. |
| controllers/message_answer.go | Introduces generateMessageAnswer and rewires streaming writes/errors to use an injected http.ResponseWriter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+48
to
+54
| func (c *ApiController) generateMessageAnswer(id string, responseWriter http.ResponseWriter, host string) { | ||
| lang := c.GetAcceptLanguage() | ||
| responseErrorStream := func(message *object.Message, errorText string) { | ||
| if err := writeMessageErrorStream(responseWriter, lang, message, errorText); err != nil { | ||
| c.ResponseError(err.Error()) | ||
| } | ||
| } |
| } | ||
| if err != nil { | ||
| if strings.Contains(err.Error(), "write tcp") { | ||
| c.ResponseError(err.Error()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
GetMessageAnswerby extracting an internal reusable message-answer entrypoint while keeping the public API behavior unchanged.Notes
This prepares the message answer flow for reuse by other internal entrypoints, such as chat pipe/webhook integrations.