fix: refactor admin permission checks into util package#2060
Merged
Conversation
- Created util/permission.go with centralized permission checking functions - Added IsChatAdmin(), IsAdminOrChatAdmin(), and IsVideoNormalUser() functions - Defined constants for user types: UserTypeChatAdmin and UserTypeVideoNormalUser - Updated all files to use new util functions instead of hardcoded checks - Added comprehensive tests for permission utility functions - All hardcoded role strings like "chat-admin" now only exist in util package Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor admin permission checks to util package
Refactor admin permission checks into util package
Dec 10, 2025
hsluoyz
added a commit
that referenced
this pull request
Dec 10, 2025
hsluoyz
added a commit
that referenced
this pull request
Dec 10, 2025
This was referenced Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoded role strings like
"chat-admin"and"video-normal-user"were scattered across controllers, routers, and object packages, making role management brittle and difficult to maintain.Changes
New
util/permission.gowith centralized permission functions:IsAdminOrChatAdmin(user)- combines system admin and chat-admin checksIsChatAdmin(user)- chat-admin role checkIsVideoNormalUser(user)- video user role checkUserTypeChatAdmin,UserTypeVideoNormalUserReplaced inline checks in 5 files:
routers/authz_filter.gocontrollers/util.go,controllers/account.go,controllers/video.goobject/util.goBefore:
After:
All role strings now exist only in
util/permission.go.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.