feat: ignore parquet migrated blocks in store gateway#8366
Merged
GiedriusS merged 2 commits intothanos-io:mainfrom Jul 16, 2025
Merged
feat: ignore parquet migrated blocks in store gateway#8366GiedriusS merged 2 commits intothanos-io:mainfrom
GiedriusS merged 2 commits intothanos-io:mainfrom
Conversation
Signed-off-by: Joel Verezhak <j.verezhak@gmail.com>
verejoel
force-pushed
the
feature/parquet-migration-flag
branch
from
2d00a9c to
ecd54da
Compare
GiedriusS
reviewed
Jul 9, 2025
cmd/thanos/store.go
Outdated
|
|
||
| cmd.Flag("disable-admin-operations", "Disable UI/API admin operations like marking blocks for deletion and no compaction.").Default("false").BoolVar(&sc.disableAdminOperations) | ||
|
|
||
| cmd.Flag("ignore-parquet-migrated-blocks", "If true, store gateway will ignore blocks that have been migrated to parquet format. This allows for safe migration from TSDB to parquet blocks.").Default("false").BoolVar(&sc.ignoreParquetMigratedBlocks) |
Member
There was a problem hiding this comment.
Again, let's always enable this, it doesn't make sense to introduce yet another flag. We already have a million of them
GiedriusS
reviewed
Jul 9, 2025
GiedriusS
reviewed
Jul 9, 2025
GiedriusS
reviewed
Jul 9, 2025
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
feature/parquet-migration-flag
branch
from
d3c47df to
b495129
Compare
GiedriusS
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a clean migration path when using the thanos-parquet-gateway. By supporting this new extension key, blocks can be optionally ignored by the store gateway metasyncers.
For additional details, see thanos-io/thanos-parquet-gateway#14
Changes
Verification
Tested locally with filesystem blocks.