objstore : implement Baidu BOS#4506
Merged
bwplotka merged 3 commits intothanos-io:mainfrom Aug 24, 2021
Merged
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
yahaa
force-pushed
the
add-baidu-bos
branch
2 times, most recently
from
8bc3703 to
28b07e9
Compare
Contributor
Author
|
@bwplotka @jojohappy Please help review this PR, thanks! |
yahaa
force-pushed
the
add-baidu-bos
branch
6 times, most recently
from
6f20f45 to
0eb9efa
Compare
GiedriusS
reviewed
Aug 3, 2021
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
There's no context.Context support? :(
bwplotka
reviewed
Aug 4, 2021
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks for this! Some comments, but generally looks amazing!
yahaa
force-pushed
the
add-baidu-bos
branch
5 times, most recently
from
87ee39b to
0992c35
Compare
bwplotka
previously approved these changes
Aug 17, 2021
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Amazing. LGTM, only suggestion towards documentation nits.
Thanks!
Signed-off-by: yahaa <1477765176@qq.com>
Signed-off-by: yahaa <1477765176@qq.com>
Contributor
|
@yahaa Can you please resolve the changelog conflicts? |
Contributor
Author
Ok i have resolved the conflicts.😁 |
bwplotka
approved these changes
Aug 24, 2021
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Amazing work! Clean, straightforward.
My instinct tells me we might have problem with BOS naming too - it might be bit cryptic, but since we allowed COS already, let's go for it 👍🏽 Thanks!
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to reimplement Baidu BOS objstore.
Reference: #1329
Changes
Verification