query: add memcached autodiscovery support#4487
Merged
GiedriusS merged 7 commits intothanos-io:mainfrom Aug 3, 2021
Merged
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
roystchiang
force-pushed
the
autodiscovery
branch
3 times, most recently
from
3644367 to
f86af27
Compare
GiedriusS
reviewed
Jul 26, 2021
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Please rebase on latest main, that should fix CircleCI
roystchiang
force-pushed
the
autodiscovery
branch
from
f86af27 to
48b421f
Compare
Signed-off-by: Roy Chiang <roychi@amazon.com>
roystchiang
force-pushed
the
autodiscovery
branch
from
48b421f to
af820e7
Compare
Signed-off-by: Roy Chiang <roychi@amazon.com>
roystchiang
force-pushed
the
autodiscovery
branch
from
0d203b9 to
0e8cbbc
Compare
Member
|
@roystchiang could you please fix the linter messages? 🤗 |
Signed-off-by: Roy Chiang <roychi@amazon.com>
roystchiang
force-pushed
the
autodiscovery
branch
from
f7add1b to
933b325
Compare
Contributor
Author
|
oops. I've fixed the linter messages now. |
Signed-off-by: Roy Chiang <roychi@amazon.com>
roystchiang
force-pushed
the
autodiscovery
branch
from
5235ee0 to
f3b2dfb
Compare
GiedriusS
reviewed
Jul 28, 2021
GiedriusS
reviewed
Jul 28, 2021
GiedriusS
reviewed
Jul 28, 2021
GiedriusS
reviewed
Jul 28, 2021
GiedriusS
reviewed
Jul 28, 2021
GiedriusS
reviewed
Jul 28, 2021
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
A few nits but overall good work 👍
roystchiang
force-pushed
the
autodiscovery
branch
from
193352b to
0ac7ee7
Compare
Signed-off-by: Roy Chiang <roychi@amazon.com>
roystchiang
force-pushed
the
autodiscovery
branch
from
0ac7ee7 to
e80b1f3
Compare
GiedriusS
previously approved these changes
Aug 2, 2021
Member
|
@roystchiang please add the DCO and let's merge 🤗 |
roystchiang
force-pushed
the
autodiscovery
branch
from
2a1c226 to
6111dfa
Compare
Member
|
@roystchiang make docs now fails :/ |
Contributor
Author
|
hahahahahaha. yeah I'm on it. sorry about that |
Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com> Signed-off-by: Roy Chiang <roychi@amazon.com>
roystchiang
force-pushed
the
autodiscovery
branch
from
6111dfa to
22ed612
Compare
GiedriusS
previously approved these changes
Aug 2, 2021
Signed-off-by: Roy Chiang <roychi@amazon.com>
GiedriusS
approved these changes
Aug 3, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Verification
I also updated the memcached config documentation so that we can close #3879