Add sorting and filtering to flags page#4403
Merged
yeya24 merged 3 commits intothanos-io:mainfrom Jul 2, 2021
Merged
Conversation
Contributor
Author
|
If I'm not wrong, the review is more on your side @onprem right ? :) |
onprem
previously approved these changes
Jul 2, 2021
Member
onprem
left a comment
onprem
left a comment
There was a problem hiding this comment.
Just a small nit in the CHANGELOG, the code looks perfect. Thanks!
Contributor
|
@Nexucis Can you please rebase? Thanks for the contribution! |
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Contributor
Author
|
@yeya24 done :) |
Contributor
Author
|
@yeya24 you need to reapprove the PR if you enable the auto merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4400