Add error log to receiver and clarify bad replica error message#4394
Merged
squat merged 5 commits intothanos-io:mainfrom Jul 2, 2021
Merged
Add error log to receiver and clarify bad replica error message#4394squat merged 5 commits intothanos-io:mainfrom
squat merged 5 commits intothanos-io:mainfrom
Conversation
Signed-off-by: Ian Billett <ibillett@redhat.com>
Signed-off-by: Ian Billett <ibillett@redhat.com>
bwplotka
reviewed
Jul 1, 2021
| func (h *Handler) handleRequest(ctx context.Context, rep uint64, tenant string, wreq *prompb.WriteRequest) error { | ||
| // The replica value in the header is one-indexed, thus we need >. | ||
| if rep > h.options.ReplicationFactor { | ||
| level.Error(h.logger).Log("err", errBadReplica, "msg", "write request rejected", |
Member
There was a problem hiding this comment.
Can we do this in the place where error is handled? Handling error twice (by returning and logging) is a bad smell 🙈
Contributor
Author
Member
There was a problem hiding this comment.
Hm... there is a risk we will handle things twice, but not a biggie! (:
Signed-off-by: Ian Billett <ibillett@redhat.com>
bwplotka
approved these changes
Jul 2, 2021
| func (h *Handler) handleRequest(ctx context.Context, rep uint64, tenant string, wreq *prompb.WriteRequest) error { | ||
| // The replica value in the header is one-indexed, thus we need >. | ||
| if rep > h.options.ReplicationFactor { | ||
| level.Error(h.logger).Log("err", errBadReplica, "msg", "write request rejected", |
Member
There was a problem hiding this comment.
Hm... there is a risk we will handle things twice, but not a biggie! (:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Billett ibillett@redhat.com
Changes
Fixes #4305
Verification
Running the integration tests from #4362 I see the following log: