Conversation
17e1da1 to
895fd18
Compare
|
This pull request seems to copy/paste code from Prometheus without the attribution required by the Apache-2 License. |
895fd18 to
a0a056b
Compare
@roidelapluie To maintain consistency in Thanos and Prometheus UI, I reused the Prometheus dark theme code. |
a0a056b to
6186032
Compare
kakkoyun
left a comment
There was a problem hiding this comment.
LGTM 🚀
Noob question: Is there a way to directly import the theme from Prometheus rather than copying over the code? It'll be hard to keep it in sync?
Currently, no. We have to publish relevant bits on npm to do that. |
Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
6186032 to
b5d37ee
Compare
|
I only fixed the merged conflict. The dismissed stale reviews is due to saacs/github#1157 |
Changes
Added dark theme
Closes #3775
Screenshots
Homepage
Status page
Store page
Verification
cd pkg/ui/react-app/ yarn start