Store: Adds the name of the instantiated memcached client to log info#3929
Merged
onprem merged 4 commits intothanos-io:mainfrom Apr 1, 2021
wiardvanrij:feature/memcached-loginfo
Merged
Store: Adds the name of the instantiated memcached client to log info#3929onprem merged 4 commits intothanos-io:mainfrom wiardvanrij:feature/memcached-loginfo
onprem merged 4 commits intothanos-io:mainfrom
wiardvanrij:feature/memcached-loginfo
Conversation
Signed-off-by: Wiard van Rij <wiard@outlook.com>
wiardvanrij
changed the title
Signed-off-by: Wiard van Rij <wiard@outlook.com>
Signed-off-by: Wiard van Rij <wiard@outlook.com>
pracucci
approved these changes
Mar 15, 2021
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
LGTM (modulo a little suggestion)
Signed-off-by: Wiard van Rij <wiard@outlook.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Relates to: #3667
Verification
Created a build but have not run e2e. Tested runtime of store.