Support max_item_size for query frontend memcached cache#3920
Merged
kakkoyun merged 1 commit intothanos-io:mainfrom Apr 20, 2021
Merged
Support max_item_size for query frontend memcached cache#3920kakkoyun merged 1 commit intothanos-io:mainfrom
kakkoyun merged 1 commit intothanos-io:mainfrom
Conversation
yeya24
force-pushed
the
support-memcached-maxitemsize
branch
from
d182a75 to
669b9b5
Compare
pracucci
previously approved these changes
Mar 12, 2021
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
LGTM (modulo a nit). Good job! 👏
Member
|
Hey @yeya24. We're going to cut a release candidate soon, is there any chance for you to rebase and push this to the finish line? |
Signed-off-by: yeya24 <yb532204897@gmail.com>
yeya24
force-pushed
the
support-memcached-maxitemsize
branch
from
669b9b5 to
c449cae
Compare
Contributor
Author
|
@kakkoyun Thank you. Please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 yb532204897@gmail.com
Changes
Fixes #3895
This pr upgrades Cortex and support
max_item_sizein query frontend Memcached config.Verification