*: Allow to disable automatically setting CORS headers#3919
Merged
onprem merged 1 commit intothanos-io:mainfrom Mar 11, 2021
Merged
*: Allow to disable automatically setting CORS headers#3919onprem merged 1 commit intothanos-io:mainfrom
onprem merged 1 commit intothanos-io:mainfrom
Conversation
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
--web.disable-corsflag to every component that exposes an API, allowing to disable automatically setting CORS headers.Verification
Ran components with and without the flag using the
scripts/quickstart.shscript and verified the headers are gone.Closes #3918
@thanos-io/thanos-maintainers