storegw: Optimized inject label stage of index lookup.#3568
Merged
Conversation
yeya24
reviewed
Dec 10, 2020
ahmad-1100
approved these changes
Dec 10, 2020
yeya24
reviewed
Dec 10, 2020
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
mergelabels-opt
branch
from
52e5e0b to
ace88ff
Compare
Member
Author
|
Ok now we are talking! Thanks @yeya24 for spotting issue! |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
mergelabels-opt
branch
from
f6a86ba to
0e372f9
Compare
Member
Author
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
khyatisoneji
pushed a commit
to khyatisoneji/thanos
that referenced
this pull request
Dec 11, 2020
* storegw: Optimized inject label stage of index lookup. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Improved helper method instead. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Updated busybox pin. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall store benchmarks are not great, something is wrong.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com