Skip to content

*: Set debug.SetPanicOnFault(true) so we can recover seg faults. [for v0.17.1]#3498

Merged
kakkoyun merged 1 commit intorelease-0.17from
set-debug
Nov 24, 2020
Merged

*: Set debug.SetPanicOnFault(true) so we can recover seg faults. [for v0.17.1]#3498
kakkoyun merged 1 commit intorelease-0.17from
set-debug

Conversation

@bwplotka
Copy link
Copy Markdown
Member

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

Related: #3497

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Copy link
Copy Markdown
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 LGTM

@kakkoyun kakkoyun merged commit 1171692 into release-0.17 Nov 24, 2020
@bwplotka bwplotka deleted the set-debug branch November 24, 2020 13:11
@bwplotka
Copy link
Copy Markdown
Member Author

Thanks. Let's see if I can quickly find root cause for SIGSEG on prometheus. If not we can do v0.17.1

@bwplotka
Copy link
Copy Markdown
Member Author

cc @metalmatze

metalmatze pushed a commit to metalmatze/thanos that referenced this pull request Dec 9, 2020
bwplotka added a commit that referenced this pull request Dec 9, 2020
* Fix query frontend regression on release v0.17.0 (#3480)

* query-frontend: make POST-request to downstream url for labels and series api endpoints (#3444)

Signed-off-by: Alexander Tunik <2braven@gmail.com>

* remove default response cache config

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* ensure order when merging multiple responses

Signed-off-by: Ben Ye <yb532204897@gmail.com>

Co-authored-by: Alexander Tunik <2braven@gmail.com>

* *: Set debug.SetPanicOnFault(true) so we can recover seg faults. (#3498)

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Prepare v0.17.1 release (#3505)

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>

* fix index out of bound bug when comparing ZLabelSets (#3520)

* fix index out of bound bug when comparing ZLabelSets

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* fix param parsing error message

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* address comment feedbacks

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* compact: do not cleanup blocks on boot (#3532)

Do not cleanup blocks on boot because in some very bad cases there could
be thousands of blocks ready-to-be deleted and doing that makes Thanos
Compact exceed `initialDelaySeconds` on k8s.

Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>

* Prepare v0.17.2 (#3543)

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>

* Properly rebase CHANGELOG.md after merging release-0.17

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>

Co-authored-by: Ben Ye <yb532204897@gmail.com>
Co-authored-by: Alexander Tunik <2braven@gmail.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants