store: Add Request Hints for Labels APIs#3469
Merged
bwplotka merged 1 commit intothanos-io:masterfrom Nov 19, 2020
Merged
Conversation
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
labels-request-hints
branch
from
6b2d465 to
7e27b80
Compare
gouthamve
added a commit
to gouthamve/cortex
that referenced
this pull request
Nov 19, 2020
This is in anticipation of thanos-io/thanos#3469 where we would need to utilise the consistency check to query for labels as well. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
pracucci
reviewed
Nov 19, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
LGTM. I just noticed a typo in a error message.
| reqHints := &hintspb.LabelValuesRequestHints{} | ||
| err := types.UnmarshalAny(req.Hints, reqHints) | ||
| if err != nil { | ||
| return nil, status.Error(codes.InvalidArgument, errors.Wrap(err, "unmarshal label names request hints").Error()) |
Contributor
There was a problem hiding this comment.
unmarshal label names request hints
Should be "label values request hints"
pracucci
pushed a commit
to cortexproject/cortex
that referenced
this pull request
Nov 19, 2020
This is in anticipation of thanos-io/thanos#3469 where we would need to utilise the consistency check to query for labels as well. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
tomwilkie
pushed a commit
to grafana/mimir
that referenced
this pull request
Jul 13, 2021
This is in anticipation of thanos-io/thanos#3469 where we would need to utilise the consistency check to query for labels as well. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Former-commit-id: 1216d00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com
Changes
This is a follow up to #3437 and this PR adds the request hints support to the LabelNames/Values APIs.
Verification
Again haven't gone beyond the unit test.