Add default value to query frontend memcached config#3398
Merged
bwplotka merged 3 commits intothanos-io:masterfrom Nov 9, 2020
Merged
Add default value to query frontend memcached config#3398bwplotka merged 3 commits intothanos-io:masterfrom
bwplotka merged 3 commits intothanos-io:masterfrom
Conversation
filippog
reviewed
Nov 4, 2020
Signed-off-by: Ben Ye <yb532204897@gmail.com>
Signed-off-by: Ben Ye <yb532204897@gmail.com>
yeya24
force-pushed
the
update-memcached-docs
branch
from
e8fab10 to
bbeaa12
Compare
bwplotka
approved these changes
Nov 9, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks!
Hopefully will make it easier to use memcache config 🤗
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
* add default value to query frontend memcached config Signed-off-by: Ben Ye <yb532204897@gmail.com> * add changelog Signed-off-by: Ben Ye <yb532204897@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye yb532204897@gmail.com
Changes
This pr adds default value to query frontend Memcached configuration. For more details, please take a look at slack thread https://cloud-native.slack.com/archives/CK5RSSC10/p1604403545480000
Verification