verify: Added extra statistics for block index; Printable on debug; Interesting results#3385
Merged
verify: Added extra statistics for block index; Printable on debug; Interesting results#3385
Conversation
kakkoyun
reviewed
Oct 30, 2020
kakkoyun
reviewed
Oct 30, 2020
kakkoyun
reviewed
Oct 30, 2020
Member
kakkoyun
left a comment
There was a problem hiding this comment.
Looks good. I think there are some unintended Config->Context transformations.
Member
Author
|
Fixed 🤗 Thanks @kakkoyun for super quick review |
Contributor
|
@bwplotka i think this is wonderful! 🎉 questions: could this data be a) machine-retrievable? and b) available in the UI? |
Member
Author
a) you mean API? Why not, feel free to add an issue for it 🤗 (This API would need to download block index though) b) Of what service? There is plan to have BucketViewer to have those features (cc @kunal-kushwaha) and to migrate such view to Prometheus |
…issue Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
2 tasks
Contributor
|
This is very interesting. Thanks! |
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
…issue (thanos-io#3385) Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was playing around a couple of statistics of real block indexes and this is crazy!
For example one customer's block from our production at Red Hat has following stats:
We can actually learn a lot here. This is a non-downsampled, 2-week block that has 8.3 Million of series.
Interesting things we can find from this 🤯 👇
SeriesAvgLifeDuration:13h7m1.399sSingleSampleSeries:398902 SingleSampleChunks:1330558.. 400k of 8.3M series have one sample, thus most likely are not usable / not graphable. This might mean some sneaky app using Prometheus as event-based system. 🤦Wonder what your blocs look like, so shipping this code so everyone can check. Even usable for blocks in Prometheus local disk e.g:
Is that healthy? @brian-brazil @pracucci @kakkoyun @s-urbaniak @gouthamve @codesome @smarterclayton ;p
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com