Conversation
bwplotka
force-pushed
the
segfault-fix
branch
8 times, most recently
from
fb84117 to
522d759
Compare
Member
Author
|
PTAL - this should be ready to go. It's blocking 0.15 release. |
Contributor
|
Generally looking good, not too familiar with the surrounding code though. |
GiedriusS
approved these changes
Aug 23, 2020
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
LGTM, just a few nits in line.
pkg/store/storepb/testutil/series.go
Outdated
| testutil.Ok(t, store.Series(c.Req, srv)) | ||
| testutil.Equals(t, len(c.ExpectedWarnings), len(srv.Warnings), "%v", srv.Warnings) | ||
| testutil.Equals(t, len(c.ExpectedSeries), len(srv.SeriesSet)) | ||
| //testutil.Equals(t, len(c.ExpectedSeries), len(srv.SeriesSet)) |
Member
Author
There was a problem hiding this comment.
Important bug, we should have it and uncomment, thanks!
bwplotka
force-pushed
the
segfault-fix
branch
2 times, most recently
from
8d3e1b3 to
267ee04
Compare
Member
Author
|
Looking on different frame limits it's really close... However actually now it shows 1MB being bit better one... |
Member
Author
|
Another one: |
bwplotka
force-pushed
the
segfault-fix
branch
2 times, most recently
from
4922fbd to
a693a66
Compare
Member
Author
|
OK, extensive tests shows really not much difference, so sticking to 1MB limit as it was previously (: |
Member
Author
|
This is without marshalling - will do marshalling later on |
…Store, fixed multitsdb benchmarks. Fixed #3013 Also: * Fixed other quite big issue with reusing chunk slice. * Fixed framing - previously it was wrongly sending single-chunk frames, taking huge amount of time. Fix: We deletage closer now to ensure multitsdb operate on valid data. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> # Conflicts: # pkg/store/tsdb_test.go # pkg/testutil/testutil.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #3013
Also:
huge amount of time.
Fix: We deletage closer now to ensure multitsdb operate on valid data.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com