Receive: Fixing auto-configuration of --receive.local-endpoint#2937
Merged
brancz merged 2 commits intothanos-io:masterfrom Jul 27, 2020
Merged
Receive: Fixing auto-configuration of --receive.local-endpoint#2937brancz merged 2 commits intothanos-io:masterfrom
brancz merged 2 commits intothanos-io:masterfrom
Conversation
Signed-off-by: Jacob Repp <jacobrepp@gmail.com>
Signed-off-by: Jacob Repp <jacobrepp@gmail.com>
jrepp
force-pushed
the
fix-receive-local-endpoint
branch
from
cafd742 to
57bcdf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated code that configures the local endpoint if --receive.local-endpoint is not specified.
Verification
Tested on a 3 node cluster in GKE using a StatefulSet deployment. In this case the node upon startup will use local hostname which includes the StatefulSet pod index, e.g: thanos-receive-us-west2-1. The GRPC port is appended and this lines up with the hash ring configuration. All nodes in hash-ring then begin to correctly participate in replication of time series.