Fix web route prefix wrapped twice#2484
Conversation
Signed-off-by: yeya24 <yb532204897@gmail.com>
|
While I am trying to fix this, I found that web route prefix is not well handled for the routes other than |
Signed-off-by: yeya24 <yb532204897@gmail.com>
|
Thanks on working on this ❤️ First of all do we know what commit introduced this bug? I think we should fix all, but on cc @squat |
|
Let us know when you wake up, we can talk offline. |
|
Also question how @fengzixu or we can help with this if you are busy. (: |
|
Hmm, the original issue mentions #2208 but that doesn't seem like the cause to me |
|
@yeya24 let's make this PR against the release-0.12 branch and then we'll merge that branch back into master once we cut the release. Let me know if you want to make the PR, otherwise I can prepare it |
|
I think Ben is US time zone, so if we want to have it sooner we need to do
it alone.
…On Tue, 21 Apr 2020 at 08:13, Lucas Servén Marín ***@***.***> wrote:
@yeya24 <https://github.com/yeya24> let's make this PR against the
release-0.12 branch and then we'll merge that branch back into master once
we cut the release. Let me know if you want to make the PR, otherwise I can
prepare it
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2484 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVA3O4NAWO33ZGSWKUTDJDRNVBS7ANCNFSM4MMZS3XA>
.
|
Thanks. Please do it. ❤️ |
|
Cool on it |
|
superseded by #2489 |
Signed-off-by: yeya24 yb532204897@gmail.com
Fixes #2483
Changes
The web route prefix is registered twice.
Verification
Tested in my local env and here