Skip to content

Fix web route prefix wrapped twice#2484

Closed
yeya24 wants to merge 2 commits intothanos-io:masterfrom
yeya24:fix-web-prefix
Closed

Fix web route prefix wrapped twice#2484
yeya24 wants to merge 2 commits intothanos-io:masterfrom
yeya24:fix-web-prefix

Conversation

@yeya24
Copy link
Copy Markdown
Contributor

@yeya24 yeya24 commented Apr 20, 2020

Signed-off-by: yeya24 yb532204897@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Fixes #2483

Changes

The web route prefix is registered twice.

Verification

Tested in my local env and here

Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24 yeya24 changed the title Fix web route prefix register twice Fix web route prefix wrapped twice Apr 21, 2020
@yeya24
Copy link
Copy Markdown
Contributor Author

yeya24 commented Apr 21, 2020

While I am trying to fix this, I found that web route prefix is not well handled for the routes other than /api/v1. I already implemented a fix for that, but I am not sure whether that fix should be included in this PR. So I opened #2486. Any ideas are welcomed!

Signed-off-by: yeya24 <yb532204897@gmail.com>
@bwplotka
Copy link
Copy Markdown
Member

Thanks on working on this ❤️

First of all do we know what commit introduced this bug? I think we should fix all, but on release-0.12 branch first so we can embed this fix to 0.12.1 or 0.12.2

cc @squat

@bwplotka
Copy link
Copy Markdown
Member

Let us know when you wake up, we can talk offline.

@bwplotka
Copy link
Copy Markdown
Member

Also question how @fengzixu or we can help with this if you are busy. (:

@squat
Copy link
Copy Markdown
Member

squat commented Apr 21, 2020

Hmm, the original issue mentions #2208 but that doesn't seem like the cause to me

@squat
Copy link
Copy Markdown
Member

squat commented Apr 21, 2020

@yeya24 let's make this PR against the release-0.12 branch and then we'll merge that branch back into master once we cut the release. Let me know if you want to make the PR, otherwise I can prepare it

@bwplotka
Copy link
Copy Markdown
Member

bwplotka commented Apr 21, 2020 via email

@yeya24
Copy link
Copy Markdown
Contributor Author

yeya24 commented Apr 21, 2020

@yeya24 let's make this PR against the release-0.12 branch and then we'll merge that branch back into master once we cut the release. Let me know if you want to make the PR, otherwise I can prepare it

@yeya24 let's make this PR against the release-0.12 branch and then we'll merge that branch back into master once we cut the release. Let me know if you want to make the PR, otherwise I can prepare it

Thanks. Please do it. ❤️

@squat
Copy link
Copy Markdown
Member

squat commented Apr 21, 2020

Cool on it

@squat
Copy link
Copy Markdown
Member

squat commented Apr 21, 2020

superseded by #2489
This fix will make in into master when the release-0.12 branch is merged into master after the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query: 404s from api path when using web.route-prefix in 0.12.0

3 participants