bucket: Set state of status prober properly#2120
Merged
bwplotka merged 3 commits intothanos-io:masterfrom Feb 11, 2020
Merged
Conversation
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
bwplotka
approved these changes
Feb 11, 2020
Member
|
Thanks! |
vankop
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Feb 28, 2020
* Set state of status prober proberly Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add bucket web to quickstart script Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add changelog Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing instruction to set probe status for bucket web UI.
Fixes #2115
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Changes
Verification
make test-localMINIO_ENABLED=1 ./scripts/quickstart.sh