.*: Introduce graceful shutdown for gRPC Servers#1687
Merged
bwplotka merged 11 commits intothanos-io:masterfrom Nov 1, 2019
Merged
.*: Introduce graceful shutdown for gRPC Servers#1687bwplotka merged 11 commits intothanos-io:masterfrom
bwplotka merged 11 commits intothanos-io:masterfrom
Conversation
Member
Author
|
This should be rebased and include the fixes that will be introduced after #1689 merged. |
3927f73 to
3c786f8
Compare
Member
Author
|
This PR might have conflicting changes with #1672 |
Member
|
My personal opinion, this PR is larger and would be harder to rebase than #1672, so I'd prefer to merge this first. |
squat
reviewed
Oct 30, 2019
squat
reviewed
Oct 30, 2019
squat
reviewed
Oct 30, 2019
squat
reviewed
Oct 30, 2019
squat
reviewed
Oct 30, 2019
squat
reviewed
Oct 30, 2019
squat
reviewed
Oct 30, 2019
squat
reviewed
Oct 30, 2019
squat
reviewed
Oct 30, 2019
bwplotka
approved these changes
Oct 30, 2019
Member
bwplotka
left a comment
There was a problem hiding this comment.
Nice, it looks good, but have some minor comments (:
bwplotka
approved these changes
Oct 31, 2019
Member
bwplotka
left a comment
There was a problem hiding this comment.
Let's go with this! Good work, thanks 👍
Let's rebase and merge.
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
d7609b4 to
e020f36
Compare
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Member
Author
|
@bwplotka Is CI failure a Netlify issue? Is it something related to these changes? |
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR,
--grpc-grace-periodCLI option to specify the period.Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Changes
--grpc-grace-periodCLI option to components which serve gRPC to set how long to wait until gRPC Server shuts down.Verification
make test-localMINIO_ENABLED=1 ./scripts/quickstart.sh