store: Filter blocks before loading it. Sort advertise labels; Added sharding e2e test.#1669
Merged
store: Filter blocks before loading it. Sort advertise labels; Added sharding e2e test.#1669
Conversation
bwplotka
requested review from
brancz,
domgreen,
jojohappy,
metalmatze and
povilasv
bwplotka
force-pushed
the
store-relabel
branch
from
f1ba562 to
30f7b87
Compare
jojohappy
approved these changes
Oct 19, 2019
Member
|
test failed ): |
bwplotka
force-pushed
the
store-relabel
branch
from
30f7b87 to
8b85077
Compare
…sharding e2e test. Fixes: #1664 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
store-relabel
branch
from
8b85077 to
f4ec30e
Compare
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
store-relabel
branch
from
3b6ac56 to
6d61779
Compare
metalmatze
approved these changes
Oct 22, 2019
Member
|
It's not super clear why CI failed, any ideas? |
Member
Author
|
Yea, I am busy with other things, but it looks like our |
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
…sharding e2e test. (#1669) * store: Filter blocks before loading it. Sort advertise labels; Added sharding e2e test. Fixes: #1664 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Trying to speed up tests a bit. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Fixed tests. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1664
Signed-off-by: Bartek Plotka bwplotka@gmail.com