Revert "query/api: properly pass downsampling param (#1144)"#1154
Merged
Revert "query/api: properly pass downsampling param (#1144)"#1154
Conversation
This reverts commit 7a767ef. # Conflicts: # CHANGELOG.md
Member
|
Just curious, wouldn't it make sense to rather remove the conversions lower in the stack? |
Member
|
That's what I was talking about in the other PR. Because otherwise IMHO we would just be kicking the can further down the road until someone in the future again will get confused about what actual unit is being used. So I propose just using |
Member
Author
|
Still, can we revert first and then talk about improvements? (: |
GiedriusS
approved these changes
May 17, 2019
Member
GiedriusS
left a comment
There was a problem hiding this comment.
Okay, so let's revert it and fix that interface in the new PR. Sorry for the inconvenience, I was completely oblivious to the querier code which divides this value once more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I am not wrong downsampling on master is broken for 2days.
This reverts commit 7a767ef.
See: #1144 (comment)
Reason:
int64only.Tests are nice but they are assuming no-one converts resolution in further stack. Let's revert this and fix the getFor as it's done here: #1146