Merged
Conversation
Member
Author
|
I plan to test this in dev on monday, Other than that, it's ready for review :) |
bwplotka
approved these changes
May 27, 2019
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM, cannot find any blocker (: LGTM 🔥
Member
Author
|
tested a bunch of components in my dev k8s cluster, it looks like it works :D |
GiedriusS
requested changes
May 28, 2019
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
This LGTM however we still have some references to gossip:
docs/component/{query,rule,sidecar,store}.md:from other components if you use gossip,I guess this part can just be removed. It comes fromcmd/thanos/flags.go.pkg/query/storeset.gohas a log message talking about gossip:duplicated address in gossip or static store nodes->duplicated address detected. There's also a comment there talking about gossip. We should nuke it.pkg/store/prometheus.goalso has a small comment about gossip meta. We should remove it 💣
Member
|
I guess it's not part of it but we should also remove gossip info from the example Grafana dashboards and the |
Member
Author
|
PTAL |
Member
Author
|
Issue: #1180 |
Member
|
Love it! Let's get rid of it finally! |
Member
Author
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove gossip 🔥
Issue
#734
Verification
Tests pass
Tested this in my k8s env, couldn't find a issue