Skip to content

Use tsconfig/jsconfig paths instead of NODE_PATH #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2020
Merged

Use tsconfig/jsconfig paths instead of NODE_PATH #701

merged 3 commits into from
Dec 21, 2020

Conversation

nickserv
Copy link
Member

Fixes #693

MatanBobi
MatanBobi reviewed Dec 1, 2020
View reviewed changes
@MatanBobi
Copy link
Member

Looks good, just left one small comment :)

@nickserv
Copy link
Member Author

I agree that it should be prominent, but I'm not sure I like how the bold text looks split up

@MatanBobi
Copy link
Member

Yeah I agree..
What about a docusaurus style callout?

@nickserv
Copy link
Member Author

That's a good idea for the future, but I'd rather stay consistent and use the same > **Note** format as the rest of the code so far.

@nickserv nickserv requested a review from MatanBobi December 21, 2020 13:36
@nickserv nickserv mentioned this pull request Dec 21, 2020
Draft
@MatanBobi
Copy link
Member

Looks good. Merging 👍🏻

@MatanBobi MatanBobi merged commit 50097a7 into master Dec 21, 2020
@nickserv nickserv deleted the nickmccurdy-patch-2 branch December 21, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatanBobi MatanBobi MatanBobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of NODE_PATH in react-testing-library with create-react-app v4
2 participants
@nickserv @MatanBobi