Skip to content

add "screen" docs #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2019
Merged

add "screen" docs #351

merged 1 commit into from
Dec 27, 2019

Conversation

kentcdodds
Copy link
Member

@kentcdodds kentcdodds mentioned this pull request Dec 13, 2019
Merged
4 tasks
valscion
valscion approved these changes Dec 18, 2019
View reviewed changes
Copy link

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and no typos spotted ☺️

alexkrolick
alexkrolick approved these changes Dec 18, 2019
View reviewed changes
Copy link
Collaborator

@alexkrolick alexkrolick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also update the RTL docs to talk about this when discussing queries. It could actually make it a lot simpler because you'd use the screen export most of the time.

@kentcdodds kentcdodds merged commit ca10a21 into master Dec 27, 2019
@kentcdodds kentcdodds deleted the pr/screen branch December 27, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valscion valscion valscion approved these changes

@alexkrolick alexkrolick alexkrolick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kentcdodds @valscion @alexkrolick