-
Notifications
You must be signed in to change notification settings - Fork 411
refactor: drop lodash
entirely
#676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would recommend moving also this dependency to the devDeps and bundling it by marking it as not external in the rollup config |
e48acd0
to
74e285c
Compare
lodash
with es-toolkit
lodash
entirely
74e285c
to
d4ede3e
Compare
d4ede3e
to
963e0d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for pinging me!
Seems like I should have made this a |
lodash
is unmaintained, big and hard to tree-shake.es-toolkit
is a drop-in replacementAs @mrginglymus mentioned in #677, we could just drop
lodash
entirelyI'm sure people from the wider @e18e ecosystem cleanup (like @43081j, @benmccann & @outslept) will be very happy to see these kind of changes as well
CC/ @chyzwar @jiahao-c @JReinhold @manudeli @okinawaa @pvargas @Salinn @TheKnarf @wojtekmaj