Skip to content

refactor: drop lodash entirely #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025
Merged

refactor: drop lodash entirely #676

merged 3 commits into from
Aug 5, 2025

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Aug 5, 2025

lodash is unmaintained, big and hard to tree-shake.
es-toolkit is a drop-in replacement

As @mrginglymus mentioned in #677, we could just drop lodash entirely

For the given use case (comparing if two values were either the same string or the same set of strings) isEqualWith was completely unnecessary


I'm sure people from the wider @e18e ecosystem cleanup (like @43081j, @benmccann & @outslept) will be very happy to see these kind of changes as well

CC/ @chyzwar @jiahao-c @JReinhold @manudeli @okinawaa @pvargas @Salinn @TheKnarf @wojtekmaj

@beeequeue
Copy link

I would recommend moving also this dependency to the devDeps and bundling it by marking it as not external in the rollup config
This would reduce the code that people have to download from 2.5mb to 3kb

@MichaelDeBoey MichaelDeBoey force-pushed the MichaelDeBoey-patch-1 branch from 74e285c to d4ede3e Compare August 5, 2025 10:36
Copy link
Contributor

@wojtekmaj wojtekmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for pinging me!

@gnapse gnapse merged commit 476c30b into main Aug 5, 2025
7 checks passed
@gnapse gnapse deleted the MichaelDeBoey-patch-1 branch August 5, 2025 13:02
@MichaelDeBoey
Copy link
Member Author

Seems like I should have made this a perf instead of refactor as now this one isn't released as a minor release unfortunately 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants