Skip to content

feat: Drop support for Node.js 14.x and Node.js 16.x and add support for Node 20.x #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2023
Merged

feat: Drop support for Node.js 14.x and Node.js 16.x and add support for Node 20.x #1255

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49ac60e
feat: Drop support for Node.js 14.x and add support for Node 20.x
MatanBobi Sep 5, 2023
d2b086a
update node version in codesandbox
MatanBobi Sep 5, 2023
5ec7c12
Merge branch 'main' into features/drop-support-for-node-14
MatanBobi Sep 5, 2023
52adb24
Merge branch 'features/drop-support-for-node-14' of github.com:MatanB…
MatanBobi Sep 5, 2023
86beed6
drop support for node 16 too
MatanBobi Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codesandbox/ci.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"installCommand": "install:csb",
"sandboxes": ["github/kentcdodds/react-testing-library-examples"],
"node": "14"
"node": "16"
}
4 changes: 2 additions & 2 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
# Otherwise we would not know if the problem is tied to the Node.js version
fail-fast: false
matrix:
node: [14, 16, 18]
node: [16, 18, 20]
runs-on: ubuntu-latest
steps:
- name: ⬇️ Checkout repo
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 16

- name: 📥 Download deps
uses: bahmutov/npm-install@v1
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"author": "Kent C. Dodds <[email protected]> (https://kentcdodds.com)",
"license": "MIT",
"engines": {
"node": ">=14"
"node": ">=16"
},
"browserslist": [
"and_chr 103",
Expand All @@ -40,7 +40,7 @@
"safari 15.5",
"samsung 17.0",
"samsung 16.0",
"node 14.0"
"node 16.0"
],
"scripts": {
"build": "kcd-scripts build --no-ts-defs --ignore \"**/__tests__/**,**/__node_tests__/**,**/__mocks__/**\" && kcd-scripts build --no-ts-defs --bundle --no-clean",
Expand Down