chore: remove deprecated query* queries and prevSubject fallback code
#130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Remove `query*` queries. Throw an error instead. Fixing requires updating all `query*` to `find*` queries. In practice this means replacing `cy.query` with `cy.find`
BREAKING CHANGE: Remove fallback that retries chaiined query that assumes no previous subject. In practice this means starting new chains if no previous subject is required.
```js
// Before
cy.findByText('Foo')
.click()
.findByText('Bar') // Element with 'Bar' text is not a child of an element with 'Foo' text
.click()
// After
cy.findByText('Foo')
.click()
cy.findByText('Bar')
.click()
```
kentcdodds
approved these changes
Mar 12, 2020
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
BREAKING CHANGE: Remove `query*` queries. Throw an error instead. Fixing requires updating all `query*` to `find*` queries. In practice this means replacing `cy.query` with `cy.find`
BREAKING CHANGE: Remove fallback that retries chaiined query that assumes no previous subject. In practice this means starting new chains if no previous subject is required.
```js
// Before
cy.findByText('Foo')
.click()
.findByText('Bar') // Element with 'Bar' text is not a child of an element with 'Foo' text
.click()
// After
cy.findByText('Foo')
.click()
cy.findByText('Bar')
.click()
```
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
BREAKING CHANGE: Remove `query*` queries. Throw an error instead. Fixing requires updating all `query*` to `find*` queries. In practice this means replacing `cy.query` with `cy.find`
BREAKING CHANGE: Remove fallback that retries chaiined query that assumes no previous subject. In practice this means starting new chains if no previous subject is required.
```js
// Before
cy.findByText('Foo')
.click()
.findByText('Bar') // Element with 'Bar' text is not a child of an element with 'Foo' text
.click()
// After
cy.findByText('Foo')
.click()
cy.findByText('Bar')
.click()
```
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
BREAKING CHANGE: Remove `query*` queries. Throw an error instead. Fixing requires updating all `query*` to `find*` queries. In practice this means replacing `cy.query` with `cy.find`
BREAKING CHANGE: Remove fallback that retries chaiined query that assumes no previous subject. In practice this means starting new chains if no previous subject is required.
```js
// Before
cy.findByText('Foo')
.click()
.findByText('Bar') // Element with 'Bar' text is not a child of an element with 'Foo' text
.click()
// After
cy.findByText('Foo')
.click()
cy.findByText('Bar')
.click()
```
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Remove
query*queries. Throw an error instead. Fixing requires updating allquery*tofind*queries. In practice this means replacingcy.querywithcy.findBREAKING CHANGE: Remove fallback that retries chaiined query that assumes no previous subject. In practice this means starting new chains if no previous subject is required.
What:
Remove deprecated code
Why:
Keep repo clean
How:
Deprecated code was deleted and tests that verified deprecated implementation was removed
Checklist: