fix(redis): Use wait strategy instead of deprecated decorator#914
Open
mschmitzer wants to merge 3 commits intotestcontainers:mainfrom
Open
fix(redis): Use wait strategy instead of deprecated decorator#914mschmitzer wants to merge 3 commits intotestcontainers:mainfrom
mschmitzer wants to merge 3 commits intotestcontainers:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
==========================================
+ Coverage 79.24% 83.05% +3.81%
==========================================
Files 15 16 +1
Lines 1277 1700 +423
Branches 154 186 +32
==========================================
+ Hits 1012 1412 +400
- Misses 219 234 +15
- Partials 46 54 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey there! Is this PR going to get merged? Maybe any help needed to get things moving? |
mschmitzer
force-pushed
the
redis-wait-strategy
branch
from
e66c6fa to
b5f854f
Compare
Member
|
please allow maintainer push to your branch or replace the content of your branch with this branch contents https://github.com/testcontainers/testcontainers-python/pull/new/redis-wait-strategy-rebase - that should resolve the issues |
Tranquility2
added
👀 intend to merge this or some version of it
🔧 fix
🛠️ needs more work
mschmitzer
force-pushed
the
redis-wait-strategy
branch
from
b5f854f to
3916302
Compare
Contributor
Author
|
@alexanderankin , sorry, I was offline a couple of days. I have updated the branch as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another part of fixing #874 (cf. #899).