Support tenant name, password and mode in OceanBase module #8737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whhe
force-pushed
the
oceanbase-image-tag
branch
from
0ea4e00 to
323946d
Compare
whhe
changed the title
whhe
force-pushed
the
oceanbase-image-tag
branch
from
a19179c to
b5649c4
Compare
|
@eddumelendez PTAL |
eddumelendez
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Thanks for raising the PR, @whhe! And sorry for the delay, somehow I missed it. I've left some comments.
modules/oceanbase/src/main/java/org/testcontainers/oceanbase/OceanBaseCEContainer.java
Outdated
Show resolved
Hide resolved
modules/oceanbase/src/main/java/org/testcontainers/oceanbase/OceanBaseCEContainer.java
Outdated
Show resolved
Hide resolved
modules/oceanbase/src/main/java/org/testcontainers/oceanbase/OceanBaseCEContainer.java
Outdated
Show resolved
Hide resolved
modules/oceanbase/src/main/java/org/testcontainers/oceanbase/OceanBaseCEContainerProvider.java
Show resolved
Hide resolved
modules/oceanbase/src/test/java/org/testcontainers/oceanbase/SimpleOceanBaseCETest.java
Show resolved
Hide resolved
modules/oceanbase/src/main/java/org/testcontainers/oceanbase/OceanBaseCEContainer.java
Outdated
Show resolved
Hide resolved
modules/oceanbase/src/main/java/org/testcontainers/oceanbase/OceanBaseCEContainer.java
Outdated
Show resolved
Hide resolved
modules/oceanbase/src/main/java/org/testcontainers/oceanbase/OceanBaseCEContainer.java
Outdated
Show resolved
Hide resolved
eddumelendez
changed the title
|
Thanks, @whhe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team has refactored the docker image recently, in addition to bugfixes, some parameters have also been adjusted. https://github.com/oceanbase/docker-images/tree/main/oceanbase-ce
We will ensure the future versions of the long-term support tag
4.2.1-ltswill be backward compatible with existing parameters, and will continue to incorporate bug fixes and other optimizations.