Skip to content

Conversation

HofmeisterAn
Copy link
Collaborator

@HofmeisterAn HofmeisterAn commented Jun 27, 2023

What does this PR do?

The pull request sets the WithResourceMapping(string, string) member obsolete. In the next release, the behavior of the member will change. The target argument, which used to be a file path, will be a directory path where the file will be copied to. Then the member will accept either a directory or file path as source argument.

WithResourceMapping("appsettings.json", "/tmp/appsettings.json")

will be

WithResourceMapping("appsettings.json", "/tmp/")

Why is it important?

In order to match the IContainer.CopyAsync APIs, it is better to ensure a consistent behavior when copying files to the container.

One aspect we should take into account is modifying the API that the target argument aligns with the corresponding source argument. If the source target argument refers to a file, then the target argument should also be treated as a file too.

Related issues

-

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 6ae19c1
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/649a861af96dff0008a1b1ff
😎 Deploy Preview https://deploy-preview-934--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn marked this pull request as ready for review June 27, 2023 06:47
@HofmeisterAn HofmeisterAn merged commit 69d91ed into develop Jun 27, 2023
@HofmeisterAn HofmeisterAn deleted the feature/support-copying-dirs-from-container-def branch June 27, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant