chore: Set WithResourceMapping(string, string) obsolete and explain the new behavior #934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The pull request sets the
WithResourceMapping(string, string)
member obsolete. In the next release, the behavior of the member will change. The target argument, which used to be a file path, will be a directory path where the file will be copied to. Then the member will accept either a directory or file path as source argument.will be
Why is it important?
In order to match the
IContainer.CopyAsync
APIs, it is better to ensure a consistent behavior when copying files to the container.One aspect we should take into account is modifying the API that the target argument aligns with the corresponding source argument. If the source target argument refers to a file, then the target argument should also be treated as a file too.
Related issues
-