A few refactors in some files#4225
Merged
stweil merged 4 commits intotesseract-ocr:mainfrom Apr 26, 2024
Merged
Conversation
stweil
reviewed
Apr 25, 2024
stweil
reviewed
Apr 25, 2024
Co-authored-by: Stefan Weil <sw@weilnetz.de>
stweil
requested changes
Apr 25, 2024
Member
stweil
left a comment
stweil
left a comment
There was a problem hiding this comment.
With my two suggested changes old and new code should be equivalent and we are safe. Maybe the original patch would be better, but it might change the output of the debug tprintf, and I am not sure about that.
Contributor
|
Just revert and dont touch that condition. |
Member
|
Often it is easier if unrelated changes like in this pull request are split in separate pull requests, for example "Remove unused local variable", "Fix typo in comment", "Simplify code by using BlobGridSearch" and so on. Then those contributions are easy to review, and they can be merged quickly. |
Co-authored-by: Stefan Weil <sw@weilnetz.de>
Co-authored-by: Stefan Weil <sw@weilnetz.de>
Contributor
Author
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
A few tiny refactors in some files.