This repository was archived by the owner on Jun 27, 2018. It is now read-only.
Flatten chained error messages #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The confusingly named
messageTextproperty ofDiagnostichas the typestring | DiagnosticMessageChain. That is, it could be a message, or a chain of error messages (which happens if you have an error nested in a type somewhere.Previously, if an error had a message chain, the output was something like
L123 [Object object]. This changes it to use the methodts.flattenDiagnosticMessageTextwhich does exactly what you'd hope.Small additional change: I don't know if it was just my own settings, but TypeScript was complaining about the line
'outDir' in this.options ? this.options.outDir : ''since it wasn't narrowing the type fromstring | undefined. I changed the condition and it seemed happier then.