-
Notifications
You must be signed in to change notification settings - Fork 214
Upgrade for JavaCPP 1.5.7 and TensorFlow 2.8.0 #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Did the framework tests pass without my PR from today (#414)? I had assumed it was an overbroad backport that broke the RNG functionality, but if it worked in TF 2.8 then that's even stranger. |
Yes, all tests pass, including everything from tensorflow-framework as is in this branch, without pull #414. I'm only seeing a "skipped" one from org.tensorflow.framework.optimizers.GradientDescentTest. |
@karllessard I'm not sure that creating a new "rawops" package with only a couple of ops is better than just leaving everything in "core", but that's what your tool picked up, so I'll leave you deal with this! |
Thanks for trying @saudet but I think the API import tooling is not working as good as before since the last few versions of TensorFlow. The number of new ops seems relatively small, I'll go through them and update their package manually. |
Ok @saudet , I just pushed the following changes to your branch:
For the latter, I tried quickly to fix the |
@saudet , any idea what this error is about? https://github.com/tensorflow/java/runs/5311689706?check_suite_focus=true#step:5:1595 Windows build is failing (again...) |
I don't think TF supports Visual Studio 2022, try to revert to 2019. If that doesn't work, try to revert to the previous version of Bazel since that could as well be caused by a regression in there. |
I doubt the bazel version we're using does either, |
We’ll see if the native build succeeds but. eventually it will fail after when compiling the Java stuff because while we’ve already migrated to jdk 11 in ndarray, we haven’t done it yet in TF Java |
That usually means there's a path somewhere that's longer than MAX_PATH. We might need to hack the build by creating a temporary junction for |
cece798
to
1870d08
Compare
1870d08
to
ddc2a5e
Compare
Everything builds and all tests pass for me, even though I almost didn't have to update anything, but a lot changes in the ops as usual, so that probably needs to be looked into before we can merge this. @karllessard