Update flatbuffers to b99332e #47
Conversation
Since flatbuffers/5104 has been merged, it is possible to use flatbuffers directly without patch. This fix update the flatbuffers to the latest one. This fix is related to 36. Signed-off-by: Yong Tang <[email protected]>
|
@BryanCutler I created this PR, as google/flatbuffers#5104 has been merged and there is no need to apply a fix any more. With this PR, you can just add the following to - out_prefix = "cpp/src/arrow/ipc/"
+ out_prefix = "cpp/src/arrow/ipc/",
+ flatc_args = [
+ "--no-union-value-namespacing",
+ "--gen-object-api",
+ ], |
|
Ok, will do. Thanks @yongtang ! |
.travis/python.configure.sh
Outdated
| @@ -9,3 +9,4 @@ chmod +x install.sh | |||
| rm -f install.sh | |||
| # Configure TensorFlow | |||
| ./configure.sh | |||
| pip install pyarrow | |||
There was a problem hiding this comment.
should this be fixed to pyarrow==0.11.1?
Signed-off-by: Yong Tang <[email protected]>
|
Thanks @BryanCutler. I updated the pyarrow version. It looks like pyarrow does not support python 3.4, so skipped the install for 3.4. |
Yeah, pyarrow stopped building for Python 3.4 since it is scheduled to be end-of-life in March this year. I should make the tests that require pyarrow optional, since we are testing against this version currently. |
Since google/flatbuffers#5104 has been merged, it is possible to use flatbuffers directly without patch. This fix update the flatbuffers to the latest one.
This fix is related to #36.
Signed-off-by: Yong Tang [email protected]