Skip to content

Bump to 0.17.1 and cherry-pick arrow/parquet related commits #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 12, 2021

Conversation

yongtang
Copy link
Member

This PR bumps version to 0.17.1 and cherry-pick arrow/parquet related commits

This is part of the effort for #1313 (comment)

Signed-off-by: Yong Tang [email protected]

Signed-off-by: Yong Tang <[email protected]>
This PR tries to address the issue raised in 1254 where reading parquet
files will results in `InvalidArgumentError: null value in column`

The issue comes from the fact that parquet's ColumnReader C++ API
`ReadBatch(...)` does not necessarily respect the number of rows
requested and may return less instead.

This PR fixes 1254.

Signed-off-by: Yong Tang <[email protected]>
* Bump Apache Arrow to 2.0.0

Also bumps Apache Thrift to 0.13.0

Signed-off-by: Yong Tang <[email protected]>

* Update code to match Arrow

Signed-off-by: Yong Tang <[email protected]>

* Bump pyarrow to 2.0.0

Signed-off-by: Yong Tang <[email protected]>

* Stay with version=1 for write_feather to pass tests

Signed-off-by: Yong Tang <[email protected]>

* Bump flatbuffers to 1.12.0

Signed-off-by: Yong Tang <[email protected]>

* Fix Windows issue

Signed-off-by: Yong Tang <[email protected]>

* Fix tests

Signed-off-by: Yong Tang <[email protected]>

* Fix Windows

Signed-off-by: Yong Tang <[email protected]>

* Remove -std=c++11 and leave default -std=c++14 for arrow build

Signed-off-by: Yong Tang <[email protected]>

* Update sha256 of libapr1

As the hash changed by the repo.

Signed-off-by: Yong Tang <[email protected]>
This PR patchs arrow to temporarily resolve the ARROW-11518 issue.

See 1281 for details

Credit to diggerk.

We will update arrow after the upstream PR is merged.

Signed-off-by: Yong Tang <[email protected]>
@yongtang yongtang force-pushed the R0.17 branch 2 times, most recently from 1390af2 to 9f71986 Compare April 11, 2021 10:56
This PR updates pulsar download link as old link does not work anymore.

Signed-off-by: Yong Tang <[email protected]>
…le system (tensorflow#1357)

* Update to use https for http file system test also registers https file system

The http test is failing as apache switched to use https for license page.

This PR makes adjustment to fix the issue.

Signed-off-by: Yong Tang <[email protected]>

* Update README.md to use https

Signed-off-by: Yong Tang <[email protected]>
@yongtang yongtang marked this pull request as ready for review April 11, 2021 21:48
@yongtang
Copy link
Member Author

The PR is ready for review now.

Copy link
Member

@kvignesh1420 kvignesh1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongtang LGTM. So the process was to:

  • create a new branch named R0.17 with the commits upto v0.17.0.
  • apply the applicable commits to the branch.
  • modify github actions to generate the whl files.

@yongtang
Copy link
Member Author

@kvignesh1420 Yes. In addition to the list, the following will also need to be done for the release:

  1. Update README.md and RELEASE.md to add entries for new release version
  2. Push wheel to pypi.org.

I will merge this PR for now. Will see if we can update the README.md and RELEASE.md and push for a release today or tomorrow.

@yongtang yongtang merged commit 6624380 into tensorflow:R0.17 Apr 12, 2021
@yongtang yongtang deleted the R0.17 branch April 12, 2021 13:50
@kvignesh1420
Copy link
Member

@yongtang sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants