Revert "update protobuf version to 3.11.4 to match tensorflow-nightly"
#1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vnvo2409 We can put a specific version in https://github.com/tensorflow/io/blob/master/tensorflow_io/core/python/ops/version_ops.py e.g., The build will automatically pin to this version. We can also wait until TF 2.5 release candidate to pin to rc version instead. |
…htly (tensorflow#1320)" This reverts commit 07d833f.
vnghia
force-pushed
the
revert-1320-update-protobuf
branch
from
4643eb6 to
edb0fc1
Compare
|
I believe we need protobuf 3.11.4 for python 3.9, so I will check TensorFlow regularly and ensure that our protobuf match TensorFlow protobuf. I think we could keep updating In addition, |
|
@vnvo2409 Thanks! 👍 |
|
@yongtang Tests are falling because of unrelated reasons, we could merge this PR |
kvignesh1420
approved these changes
Mar 12, 2021
michaelbanfield
pushed a commit
to michaelbanfield/io
that referenced
this pull request
Mar 30, 2021
…htly (tensorflow#1320)" (tensorflow#1323) This reverts commit 07d833f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1320
The commit tensorflow/tensorflow@e71367f in TensorFlow is reverted by tensorflow/tensorflow@bd3e005. Please wait for
tf-nightly 2.5.0.dev20210310before merging this PR.Could we freeze the
tf-nightlyversion @yongtang ?