Skip to content

Add python 3.9 on Windows #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2021
Merged

Add python 3.9 on Windows #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b78be91
Add python 3.9 on Windows
yongtang Feb 27, 2021
1c1b445
Enable Windows as tf-nightly for windows is available
yongtang Feb 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python: ['3.6', '3.7', '3.8']
python: ['3.6', '3.7', '3.8', '3.9']
steps:
- uses: actions/checkout@v2
- uses: actions/download-artifact@v1
Expand Down Expand Up @@ -393,7 +393,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python: ['3.7', '3.8']
python: ['3.7', '3.8', '3.9']
steps:
- uses: actions/checkout@v2
- uses: actions/download-artifact@v1
Expand Down Expand Up @@ -479,6 +479,10 @@ jobs:
with:
name: Windows-3.8-wheel
path: Windows-3.8-wheel
- uses: actions/download-artifact@v1
with:
name: Windows-3.9-wheel
path: Windows-3.9-wheel
- run: |
set -e -x
mkdir -p wheelhouse
Expand All @@ -492,6 +496,7 @@ jobs:
cp Windows-3.6-wheel/*.whl wheelhouse/
cp Windows-3.7-wheel/*.whl wheelhouse/
cp Windows-3.8-wheel/*.whl wheelhouse/
cp Windows-3.9-wheel/*.whl wheelhouse/
ls -la wheelhouse/
sha256sum wheelhouse/*.whl
- uses: actions/upload-artifact@v1
Expand Down Expand Up @@ -625,7 +630,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python: ['3.6', '3.7', 3.8]
python: ['3.6', '3.7', '3.8', '3.9']
steps:
- uses: actions/download-artifact@v1
with:
Expand Down Expand Up @@ -699,6 +704,10 @@ jobs:
with:
name: Windows-3.8-nightly
path: Windows-3.8-nightly
- uses: actions/download-artifact@v1
with:
name: Windows-3.9-nightly
path: Windows-3.9-nightly
- run: |
set -e -x
mkdir -p dist
Expand All @@ -712,6 +721,7 @@ jobs:
cp Windows-3.6-nightly/*.whl dist/
cp Windows-3.7-nightly/*.whl dist/
cp Windows-3.8-nightly/*.whl dist/
cp Windows-3.9-nightly/*.whl dist/
ls -la dist/
sha256sum dist/*.whl
- uses: pypa/gh-action-pypi-publish@master
Expand Down
12 changes: 0 additions & 12 deletions tensorflow_io/core/plugins/file_system_plugins.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,12 @@ void TF_InitPlugin(TF_FilesystemPluginInfo* info) {
tensorflow::io::az::ProvideFilesystemSupportFor(&info->ops[0], "az");
tensorflow::io::http::ProvideFilesystemSupportFor(&info->ops[1], "http");
if (enable_legacy == "true" || enable_legacy == "1") {
// TODO: enable on windows once tf-nightly releases windows build
// that contains TF_ENABLE_LEGACY_FILESYSTEM.
#if defined(_MSC_VER)
tensorflow::io::s3::ProvideFilesystemSupportFor(&info->ops[2], "s3");
#else
tensorflow::io::s3::ProvideFilesystemSupportFor(&info->ops[2], "s3e");
#endif
tensorflow::io::hdfs::ProvideFilesystemSupportFor(&info->ops[3], "hdfse");
tensorflow::io::hdfs::ProvideFilesystemSupportFor(&info->ops[4], "viewfse");
tensorflow::io::hdfs::ProvideFilesystemSupportFor(&info->ops[5], "hare");
} else {
// TODO: enable on windows once tf-nightly releases windows build
// that contains TF_ENABLE_LEGACY_FILESYSTEM.
#if defined(_MSC_VER)
tensorflow::io::s3::ProvideFilesystemSupportFor(&info->ops[2], "s3e");
#else
tensorflow::io::s3::ProvideFilesystemSupportFor(&info->ops[2], "s3");
#endif
tensorflow::io::hdfs::ProvideFilesystemSupportFor(&info->ops[3], "hdfs");
tensorflow::io::hdfs::ProvideFilesystemSupportFor(&info->ops[4], "viewfs");
tensorflow::io::hdfs::ProvideFilesystemSupportFor(&info->ops[5], "har");
Expand Down